Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 163493002: Fix race condition on kiosk app launch. (Closed)

Created:
6 years, 10 months ago by Mattias Nissler (ping if slow)
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fix race condition on kiosk app launch. The previous code would fail for the case of the app window already present before the observer gets registered. BUG=chromium:343540 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M chrome/browser/chromeos/login/app_launch_controller.cc View 4 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
Please review.
6 years, 10 months ago (2014-02-13 13:27:39 UTC) #1
xiyuan
lgtm
6 years, 10 months ago (2014-02-13 15:29:56 UTC) #2
Mattias Nissler (ping if slow)
The CQ bit was checked by mnissler@chromium.org
6 years, 10 months ago (2014-02-13 15:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/163493002/1
6 years, 10 months ago (2014-02-13 15:37:07 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 18:28:25 UTC) #5
Message was sent while issue was closed.
Change committed as 251088

Powered by Google App Engine
This is Rietveld 408576698