win_toolchain/package_from_installed.py - Issue 1634923002: Add the possibility to keep several version of the VS toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/package_from_installed.py

Issue 1634923002: Add the possibility to keep several version of the VS toolchain. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Use the VC dir to calculate the toolchain age Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win_toolchain/package_from_installed.py

diff --git a/win_toolchain/package_from_installed.py b/win_toolchain/package_from_installed.py

index c71de3dab9f78809f6e2f5310397c732415729e7..d3f8be06418fd8f278d825b6e815aa996c58bcd5 100644

--- a/win_toolchain/package_from_installed.py

+++ b/win_toolchain/package_from_installed.py

@@ -248,7 +248,7 @@ def RenameToSha1(output):

os.path.join(old_dir, output), 'r', zipfile.ZIP_DEFLATED, True) as zf:

zf.extractall(rel_dir)

print 'Hashing...'

- sha1 = get_toolchain_if_necessary.CalculateHash(rel_dir)

+ sha1 = get_toolchain_if_necessary.CalculateHash(rel_dir, None)

os.chdir(old_dir)

shutil.rmtree(tempdir)

final_name = sha1 + '.zip'

« no previous file with comments | « win_toolchain/get_toolchain_if_necessary.py ('k') | no next file » | no next file with comments »