Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1634903003: Remove restriction with method resolution in background compilation, now that (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index 83f3cb575b932f8bc4e61a860e2bc393a14b0138..ecc3350bdb83e2f304de54910d95d89f55065812 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -225,14 +225,6 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
// finalized yet.
return false;
}
- // Do not run the optimization below if in background compilation since
- // resolution of method extractor functions may create new signature
- // classes.
- // TODO(regis): Remove test for background compilation once signature
- // classes are not generated any longer.
- if (!thread()->IsMutatorThread()) {
- return false;
- }
const Array& args_desc_array = Array::Handle(Z,
ArgumentsDescriptor::New(call->ArgumentCount(),
call->argument_names()));
@@ -284,12 +276,7 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
}
// Check if getter or setter in function's class and class is currently leaf.
- // Do not run the optimization below if in background compilation since
- // resolution of getter functions may create new signature classes.
- // TODO(regis): Remove test for background compilation once signature classes
- // are not generated any longer.
- if (thread()->IsMutatorThread() &&
- FLAG_guess_icdata_cid &&
+ if (FLAG_guess_icdata_cid &&
((call->token_kind() == Token::kGET) ||
(call->token_kind() == Token::kSET))) {
const Class& owner_class = Class::Handle(Z, function().Owner());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698