Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634863002: Introduce CodeSourceMap object to hold pc -> token position mappings (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce CodeSourceMap object to hold pc -> token position mappings BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b5259257bd237af023bfd63e8d7ac6036dcf125f

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -8 lines) Patch
M runtime/vm/code_descriptors.h View 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +81 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 8 chunks +139 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 11 months ago (2016-01-25 20:55:57 UTC) #3
rmacnak
Crash requesting allocation profile. runtime/vm/class_table.h:61: error: expected: instance_size > 0 Probably need to teach the ...
4 years, 10 months ago (2016-01-26 18:36:46 UTC) #4
rmacnak
lgtm https://chromiumcodereview.appspot.com/1634863002/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://chromiumcodereview.appspot.com/1634863002/diff/20001/runtime/vm/raw_object.h#newcode1207 runtime/vm/raw_object.h:1207: // CodeSourceMap stores a mapping between code PC ...
4 years, 10 months ago (2016-01-26 20:33:50 UTC) #5
Cutch
https://chromiumcodereview.appspot.com/1634863002/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://chromiumcodereview.appspot.com/1634863002/diff/20001/runtime/vm/raw_object.h#newcode1207 runtime/vm/raw_object.h:1207: // CodeSourceMap stores a mapping between code PC ranges ...
4 years, 10 months ago (2016-01-26 21:06:57 UTC) #6
Cutch
4 years, 10 months ago (2016-01-26 21:07:26 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b5259257bd237af023bfd63e8d7ac6036dcf125f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698