Force logo to be clickable even if animated doodle is a static PNG

Force logo to be clickable even if animated doodle is a static PNG

There are times where the doodle server sends PNG instead of GIFs in the
url field of image data. This will make BaseGifDrawable to think that
its content is not valid and thus we will always try to download the
valid PNG again on click. This behavior is corrected by this CL.

BUG=580624
Committed: https://crrev.com/24470ffc1d82cc77d72a6d5507090967dea95a99
Cr-Commit-Position: refs/heads/master@{#371356}

[Ian Wen, 2016-01-25 19:18:45]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2016-01-25 19:55:31]

Does onAnimatedLogoAvailable() always get called, even if the download fails,
parsing fails, etc?

[Ian Wen, 2016-01-25 21:10:23]

If download fails, the loading "spinner" will be showing. And if the user clicks
the view again, we try to download it again.

Downloading failure is not the case that I'm worried about. This CL is about
server sending url as static image..

[newt (away), 2016-01-25 22:11:13]

Ok, since the spinner is showing, I'm fine with not loading the search page.

lgtm

[Ian Wen, 2016-01-25 23:03:23]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2016-01-25 23:11:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1634843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1634843002/1

[commit-bot: I haz the power, 2016-01-26 00:01:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 00:02:27]

Description was changed from

==========
Force logo to be clickable even if animated doodle is a static PNG

There are times where the doodle server sends PNG instead of GIFs in the
url field of image data. This will make BaseGifDrawable to think that
its content is not valid and thus we will always try to download the
valid PNG again on click. This behavior is corrected by this CL.

BUG=580624
==========

to

==========
Force logo to be clickable even if animated doodle is a static PNG

There are times where the doodle server sends PNG instead of GIFs in the
url field of image data. This will make BaseGifDrawable to think that
its content is not valid and thus we will always try to download the
valid PNG again on click. This behavior is corrected by this CL.

BUG=580624

Committed: https://crrev.com/24470ffc1d82cc77d72a6d5507090967dea95a99
Cr-Commit-Position: refs/heads/master@{#371356}
==========

[commit-bot: I haz the power, 2016-01-26 00:02:27]

Patchset 1 (id:??) landed as
https://crrev.com/24470ffc1d82cc77d72a6d5507090967dea95a99
Cr-Commit-Position: refs/heads/master@{#371356}