Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 163483003: Use SkRRect to store rects in SkClipStack::Element (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use SkRRect to store rects in SkClipStack::Element BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13544

Patch Set 1 #

Patch Set 2 : Get rrect type before copying #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M include/core/SkClipStack.h View 1 5 chunks +10 lines, -9 lines 2 comments Download
M src/core/SkClipStack.cpp View 7 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
6 years, 10 months ago (2014-02-16 17:36:29 UTC) #1
bsalomon
On 2014/02/16 17:36:29, bsalomon wrote: ping
6 years, 10 months ago (2014-02-21 19:08:02 UTC) #2
robertphillips
Ooops - thought this had already landed. lgtm + a question. https://codereview.chromium.org/163483003/diff/50001/include/core/SkClipStack.h File include/core/SkClipStack.h (right): ...
6 years, 10 months ago (2014-02-21 19:12:02 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 19:14:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/163483003/50001
6 years, 10 months ago (2014-02-21 19:15:03 UTC) #5
bsalomon
https://codereview.chromium.org/163483003/diff/50001/include/core/SkClipStack.h File include/core/SkClipStack.h (right): https://codereview.chromium.org/163483003/diff/50001/include/core/SkClipStack.h#newcode135 include/core/SkClipStack.h:135: case kRect_Type: On 2014/02/21 19:12:02, robertphillips wrote: > Why ...
6 years, 10 months ago (2014-02-21 19:20:02 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 20:09:17 UTC) #7
Message was sent while issue was closed.
Change committed as 13544

Powered by Google App Engine
This is Rietveld 408576698