chrome_elf/chrome_elf_constants.cc - Issue 1634793002: Add a comment on PRODUCT_STRING_PATH usage in chrome_elf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/chrome_elf_constants.cc

Issue 1634793002: Add a comment on PRODUCT_STRING_PATH usage in chrome_elf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adapt comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/chrome_elf_constants.cc

diff --git a/chrome_elf/chrome_elf_constants.cc b/chrome_elf/chrome_elf_constants.cc

index 2182268a0cfec8f074af106f261c6942f2a36fa8..76560228cd6be744988a39f27fcd4428c11d2b1d 100644

--- a/chrome_elf/chrome_elf_constants.cc

+++ b/chrome_elf/chrome_elf_constants.cc

@@ -5,6 +5,9 @@

#include "chrome_elf/chrome_elf_constants.h"

#if defined(GOOGLE_CHROME_BUILD)

+// Using PRODUCT_STRING_PATH will make Google Chrome and Canary configurations

+// collide. This was deemed to be the best option due to ELF's inability to

+// depend on BrowserDistribution. http://crbug.com/577820

#define PRODUCT_STRING_PATH L"Google\\Chrome"

#elif defined(CHROMIUM_BUILD)

#define PRODUCT_STRING_PATH L"Chromium"

« no previous file with comments | « no previous file | no next file » | no next file with comments »