Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634743003: Componentize TestToolbarModel (Closed)

Created:
4 years, 11 months ago by blundell
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tfarina, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize TestToolbarModel This will be needed by upcoming CL that componentizes omnibox_edit_unittest.cc. TBR=jochen Committed: https://crrev.com/44f5d372c6f04891100405da321c2e421c222673 Cr-Commit-Position: refs/heads/master@{#372097}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Add dependency on //ui/views #

Patch Set 4 : Fix gyp dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -154 lines) Patch
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/ui/toolbar/test_toolbar_model.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/ui/toolbar/test_toolbar_model.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/toolbar.gypi View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M components/toolbar/BUILD.gn View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M components/toolbar/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/toolbar/test_toolbar_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/toolbar/test_toolbar_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
blundell
4 years, 11 months ago (2016-01-26 15:40:32 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/1634743003/diff/20001/components/toolbar/DEPS File components/toolbar/DEPS (right): https://codereview.chromium.org/1634743003/diff/20001/components/toolbar/DEPS#newcode2 components/toolbar/DEPS:2: "+components/grit", Is it intentional that this says /grit ...
4 years, 11 months ago (2016-01-26 16:35:13 UTC) #3
blundell
https://codereview.chromium.org/1634743003/diff/20001/components/toolbar/DEPS File components/toolbar/DEPS (right): https://codereview.chromium.org/1634743003/diff/20001/components/toolbar/DEPS#newcode2 components/toolbar/DEPS:2: "+components/grit", On 2016/01/26 16:35:13, Peter Kasting wrote: > Is ...
4 years, 10 months ago (2016-01-28 08:48:54 UTC) #4
blundell
TBR=jochen for //chrome/test/BUILD.gn
4 years, 10 months ago (2016-01-28 08:49:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634743003/20001
4 years, 10 months ago (2016-01-28 08:50:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/117315)
4 years, 10 months ago (2016-01-28 09:49:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634743003/60001
4 years, 10 months ago (2016-01-28 12:50:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/172744)
4 years, 10 months ago (2016-01-28 15:26:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634743003/60001
4 years, 10 months ago (2016-01-28 15:28:05 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-01-28 16:27:59 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:28:59 UTC) #22
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/44f5d372c6f04891100405da321c2e421c222673
Cr-Commit-Position: refs/heads/master@{#372097}

Powered by Google App Engine
This is Rietveld 408576698