Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 163473008: Make pretty_print.py look for a histograms.xml in the current working directory first. (Closed)

Created:
6 years, 10 months ago by engedy
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, gavinp
Visibility:
Public.

Description

Make pretty_print.py look for a histograms.xml in the current working directory first. This will allow the script to be used with files in directories other than tools/metrics/histograms. Furthermore, print the relative path of the histograms.xml file actually used to avoid confusion. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M tools/metrics/histograms/pretty_print.py View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
engedy
@Ilya: please take a look. This is in response to https://codereview.chromium.org/121403002.
6 years, 10 months ago (2014-02-14 15:19:54 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 10 months ago (2014-02-14 15:36:40 UTC) #2
engedy
The CQ bit was checked by engedy@chromium.org
6 years, 10 months ago (2014-02-14 16:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/163473008/1
6 years, 10 months ago (2014-02-14 16:04:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 18:49:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264387
6 years, 10 months ago (2014-02-14 18:49:02 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-14 21:42:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/163473008/1
6 years, 10 months ago (2014-02-14 21:45:04 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 00:15:41 UTC) #9
Message was sent while issue was closed.
Change committed as 251449

Powered by Google App Engine
This is Rietveld 408576698