Fix exception type to ArgumentError instead of out of memory when checking the length argment of ty…

runtime/lib/typed_data.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
@@ skipping 24 matching lines @@
         (length_in_bytes / element_size_in_bytes)));
     const Array& args = Array::Handle(Array::New(1));
     args.SetAt(0, error);
     Exceptions::ThrowByType(Exceptions::kRange, args);
   }
 }
 
 
 // Checks to see if a length will not result in an OOM error.
 static void LengthCheck(intptr_t len, intptr_t max) {
-  if (len > max) {
+  if (len < 0 || len > max) {
     const String& error = String::Handle(String::NewFormatted(
-        "insufficient memory to allocate a TypedData object of length (%"Pd")",
-        len));
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, error);
-    Exceptions::ThrowByType(Exceptions::kOutOfMemory, args);
-  } else if (len < 0) {
-    const String& error = String::Handle(String::NewFormatted(
-        "%"Pd" must be greater than 0", len));

[hausner, 2013/06/11 20:20:14]

Should the message include the word TypedData or will the origin/meaning of the
message be clear to the recipient either way?

[siva, 2013/06/11 20:33:39]

It should be clear based on the stack trace.
Dropped TypedData from the error string.

On 2013/06/11 20:20:14, hausner wrote:

+        "Length (%"Pd") of TypedData object must be in range [0..%"Pd"]",
+        len, max));
     const Array& args = Array::Handle(Array::New(1));
     args.SetAt(0, error);
     Exceptions::ThrowByType(Exceptions::kArgument, args);
   }
 }
 
 
   static void PeerFinalizer(Dart_WeakPersistentHandle handle, void* peer) {
   Dart_DeleteWeakPersistentHandle(handle);
   OS::AlignedFree(peer);
@@ skipping 362 matching lines @@
     value = bit_cast<double>(
         Utils::HostToLittleEndian64(bit_cast<uint64_t>(value)));
   } else {
     value = bit_cast<double>(
         Utils::HostToBigEndian64(bit_cast<uint64_t>(value)));
   }
   return Double::New(value);
 }
 
 }  // namespace dart