Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

Issue 1634693002: Fix race condition in InstallerDelegateTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove flaky test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
index 29a1c5fac99aaed98f12941f1a36f3b64210cca3..63fd5736eaef1f110ac66c88acc579e9a8ae4e68 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.banners;
import android.content.pm.PackageInfo;
import android.os.HandlerThread;
-import android.test.FlakyTest;
import android.test.InstrumentationTestCase;
import android.test.mock.MockPackageManager;
import android.test.suitebuilder.annotation.SmallTest;
@@ -91,14 +90,6 @@ public class InstallerDelegateTest extends InstrumentationTestCase
private void startMonitoring() throws InterruptedException {
mTestDelegate.start();
mInstallStarted = true;
-
- // Wait until we know that the Thread is running the InstallerDelegate task.
- CriteriaHelper.pollForCriteria(new Criteria() {
- @Override
- public boolean isSatisfied() {
- return mTestDelegate.isRunning();
- }
- });
}
private void checkResults(boolean expectedResult) throws InterruptedException {
@@ -159,8 +150,6 @@ public class InstallerDelegateTest extends InstrumentationTestCase
/**
* Makes sure that the runnable isn't called until returning from start().
*/
- /* Appears to be flaky crbug.com/542627 */
- @FlakyTest
@SmallTest
public void testRunnableRaceCondition() throws InterruptedException {
mPackageManager.isInstalled = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698