Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1634683003: Remove several more unused parser values. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove several more unused parser values. unused progressive enum unused members m_bFileStream, m_dwWordPos Remove PDFWORD_* types R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e24ea22700c9fc534d40cc510d59c453aa9d0ddb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -35 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 4 chunks +2 lines, -12 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +0 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 4 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, last of the batch.
4 years, 11 months ago (2016-01-25 21:56:16 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-25 22:13:09 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-25 23:09:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e24ea22700c9fc534d40cc510d59c453aa9d0ddb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698