Add chrome clang tests as custom targets instead of tests.

Add chrome clang tests as custom targets instead of tests.

It seems like tests don't create an actual target to use for
add_dependencies(). With add_test(), CMake always fires this warning:
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "plugins_test" of target "cr-check-all" does not
  exist.
Call Stack (most recent call first):
  /usr/local/google/ssd/src/chrome/src/tools/clang/plugins/CMakeLists.txt:28 (cr_add_test)
This warning is for project developers.  Use -Wno-dev to suppress it.

BUG=none

Committed: https://crrev.com/e64fc662ec5670fcb5b6562f0ba2e47af1043718
Cr-Commit-Position: refs/heads/master@{#371553}

[dcheng, 2016-01-25 23:54:25]

dcheng@chromium.org changed reviewers:
+ hans@chromium.org

[dcheng, 2016-01-25 23:54:25]

The warning is spammy and has been bugging me for a couple months.

[dcheng, 2016-01-25 23:54:34]

(Also, I verified that the tests still run)

[hans, 2016-01-26 18:33:07]

lgtm

[dcheng, 2016-01-26 18:36:38]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-26 18:37:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1634593006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1634593006/1

[commit-bot: I haz the power, 2016-01-26 19:13:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 19:14:02]

Description was changed from

==========
Add chrome clang tests as custom targets instead of tests.

It seems like tests don't create an actual target to use for
add_dependencies(). With add_test(), CMake always fires this warning:
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "plugins_test" of target "cr-check-all" does not
  exist.
Call Stack (most recent call first):
  /usr/local/google/ssd/src/chrome/src/tools/clang/plugins/CMakeLists.txt:28
(cr_add_test)
This warning is for project developers.  Use -Wno-dev to suppress it.

BUG=none
==========

to

==========
Add chrome clang tests as custom targets instead of tests.

It seems like tests don't create an actual target to use for
add_dependencies(). With add_test(), CMake always fires this warning:
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "plugins_test" of target "cr-check-all" does not
  exist.
Call Stack (most recent call first):
  /usr/local/google/ssd/src/chrome/src/tools/clang/plugins/CMakeLists.txt:28
(cr_add_test)
This warning is for project developers.  Use -Wno-dev to suppress it.

BUG=none

Committed: https://crrev.com/e64fc662ec5670fcb5b6562f0ba2e47af1043718
Cr-Commit-Position: refs/heads/master@{#371553}
==========

[commit-bot: I haz the power, 2016-01-26 19:14:03]

Patchset 1 (id:??) landed as
https://crrev.com/e64fc662ec5670fcb5b6562f0ba2e47af1043718
Cr-Commit-Position: refs/heads/master@{#371553}

[dcheng, 2016-02-02 07:45:02]

So upon further inspection, this appears to cause the plugin tests to /always/
run. I'm going to manually revert this tomorrow and try to find a better
solution.