Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634573002: SK_SUPPORT_LEGACY_DRAWFLTER typo (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
dogben, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
f(malita)
I can't spell, but at least I'm consistent :) This wouldn't be a big deal, ...
4 years, 11 months ago (2016-01-25 14:03:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634573002/1
4 years, 11 months ago (2016-01-25 14:04:02 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 14:14:37 UTC) #8
reed1
lgtm
4 years, 11 months ago (2016-01-25 14:15:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634573002/1
4 years, 11 months ago (2016-01-25 14:23:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/53d9f1cfbd5ddbf57c2f22b9e613ce48e5b2896c
4 years, 11 months ago (2016-01-25 14:23:57 UTC) #13
dogben
4 years, 11 months ago (2016-01-25 16:02:20 UTC) #14
Message was sent while issue was closed. 
On 2016/01/25 at 14:03:44, fmalita wrote:
> I can't spell, but at least I'm consistent :)
> 
> This wouldn't be a big deal, except Ben added more guards for Google3 with the
correct spelling.

Sorry! My fault for typing rather than copy/pasting.

Powered by Google App Engine
This is Rietveld 408576698