src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1634553002: Fix bug where generators got closed prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1634553002: Fix bug where generators got closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 757c672eb8d9a39e8e6d86c520ebf40f5742b8a2..fd6cbaa443b7634b6cb18b617f887b3e6f33d704 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1868,10 +1868,6 @@ void FullCodeGenerator::VisitYield(Yield* expr) {

}

case Yield::kFinal: {

- VisitForAccumulatorValue(expr->generator_object());

- __ mov(FieldOperand(result_register(),

- JSGeneratorObject::kContinuationOffset),

- Immediate(Smi::FromInt(JSGeneratorObject::kGeneratorClosed)));

// Pop value from top-of-stack slot, box result into result register.

EmitCreateIteratorResult(true);

EmitUnwindBeforeReturn();