Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 1634553002: Fix bug where generators got closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1895 matching lines...) Expand 10 before | Expand all | Expand 10 after
1906 __ bind(&post_runtime); 1906 __ bind(&post_runtime);
1907 __ pop(result_register()); 1907 __ pop(result_register());
1908 EmitReturnSequence(); 1908 EmitReturnSequence();
1909 1909
1910 __ bind(&resume); 1910 __ bind(&resume);
1911 context()->Plug(result_register()); 1911 context()->Plug(result_register());
1912 break; 1912 break;
1913 } 1913 }
1914 1914
1915 case Yield::kFinal: { 1915 case Yield::kFinal: {
1916 VisitForAccumulatorValue(expr->generator_object());
1917 __ LoadSmiLiteral(r4, Smi::FromInt(JSGeneratorObject::kGeneratorClosed));
1918 __ StoreP(r4, FieldMemOperand(result_register(),
1919 JSGeneratorObject::kContinuationOffset),
1920 r0);
1921 // Pop value from top-of-stack slot, box result into result register. 1916 // Pop value from top-of-stack slot, box result into result register.
1922 EmitCreateIteratorResult(true); 1917 EmitCreateIteratorResult(true);
1923 EmitUnwindBeforeReturn(); 1918 EmitUnwindBeforeReturn();
1924 EmitReturnSequence(); 1919 EmitReturnSequence();
1925 break; 1920 break;
1926 } 1921 }
1927 1922
1928 case Yield::kDelegating: { 1923 case Yield::kDelegating: {
1929 VisitForStackValue(expr->generator_object()); 1924 VisitForStackValue(expr->generator_object());
1930 1925
(...skipping 2858 matching lines...) Expand 10 before | Expand all | Expand 10 after
4789 return ON_STACK_REPLACEMENT; 4784 return ON_STACK_REPLACEMENT;
4790 } 4785 }
4791 4786
4792 DCHECK(interrupt_address == 4787 DCHECK(interrupt_address ==
4793 isolate->builtins()->OsrAfterStackCheck()->entry()); 4788 isolate->builtins()->OsrAfterStackCheck()->entry());
4794 return OSR_AFTER_STACK_CHECK; 4789 return OSR_AFTER_STACK_CHECK;
4795 } 4790 }
4796 } // namespace internal 4791 } // namespace internal
4797 } // namespace v8 4792 } // namespace v8
4798 #endif // V8_TARGET_ARCH_PPC 4793 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698