Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1634553002: Fix bug where generators got closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1940 matching lines...) Expand 10 before | Expand all | Expand 10 after
1951 __ bind(&post_runtime); 1951 __ bind(&post_runtime);
1952 __ pop(result_register()); 1952 __ pop(result_register());
1953 EmitReturnSequence(); 1953 EmitReturnSequence();
1954 1954
1955 __ bind(&resume); 1955 __ bind(&resume);
1956 context()->Plug(result_register()); 1956 context()->Plug(result_register());
1957 break; 1957 break;
1958 } 1958 }
1959 1959
1960 case Yield::kFinal: { 1960 case Yield::kFinal: {
1961 VisitForAccumulatorValue(expr->generator_object());
1962 __ mov(r1, Operand(Smi::FromInt(JSGeneratorObject::kGeneratorClosed)));
1963 __ str(r1, FieldMemOperand(result_register(),
1964 JSGeneratorObject::kContinuationOffset));
1965 // Pop value from top-of-stack slot, box result into result register. 1961 // Pop value from top-of-stack slot, box result into result register.
1966 EmitCreateIteratorResult(true); 1962 EmitCreateIteratorResult(true);
1967 EmitUnwindBeforeReturn(); 1963 EmitUnwindBeforeReturn();
1968 EmitReturnSequence(); 1964 EmitReturnSequence();
1969 break; 1965 break;
1970 } 1966 }
1971 1967
1972 case Yield::kDelegating: { 1968 case Yield::kDelegating: {
1973 VisitForStackValue(expr->generator_object()); 1969 VisitForStackValue(expr->generator_object());
1974 1970
(...skipping 2878 matching lines...) Expand 10 before | Expand all | Expand 10 after
4853 DCHECK(interrupt_address == 4849 DCHECK(interrupt_address ==
4854 isolate->builtins()->OsrAfterStackCheck()->entry()); 4850 isolate->builtins()->OsrAfterStackCheck()->entry());
4855 return OSR_AFTER_STACK_CHECK; 4851 return OSR_AFTER_STACK_CHECK;
4856 } 4852 }
4857 4853
4858 4854
4859 } // namespace internal 4855 } // namespace internal
4860 } // namespace v8 4856 } // namespace v8
4861 4857
4862 #endif // V8_TARGET_ARCH_ARM 4858 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698