Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1634513002: [heap] Move symbols and internalized strings to global header (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move symbols and internalized strings to global header BUG= R=hpayer@chromium.org Committed: https://crrev.com/518796922ac07f55c869c660e64029fc6414939c Cr-Commit-Position: refs/heads/master@{#33506}

Patch Set 1 : #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -192 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/heap-symbols.h View 1 chunk +201 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +1 line, -192 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Michael Lippautz
4 years, 11 months ago (2016-01-25 10:50:07 UTC) #6
Hannes Payer (out of office)
lgtm
4 years, 11 months ago (2016-01-25 13:39:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634513002/20001
4 years, 11 months ago (2016-01-26 08:47:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/12700)
4 years, 11 months ago (2016-01-26 08:53:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634513002/40001
4 years, 11 months ago (2016-01-26 08:57:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-26 09:23:15 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 09:24:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/518796922ac07f55c869c660e64029fc6414939c
Cr-Commit-Position: refs/heads/master@{#33506}

Powered by Google App Engine
This is Rietveld 408576698