Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1634443002: Revert "Implement GpuArcVideoService for arc video accelerator" (Closed)

Created:
4 years, 11 months ago by kcwu
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, davemoore+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Implement GpuArcVideoService for arc video accelerator" content/ incorrectly depends on components/arc. Revert first before work out how to fix it properly. This reverts commit daa96926c4bd58df2790c0e12fc92d858243ed0a. BUG=b/25057601 TBR=holte Committed: https://crrev.com/55e2b82591a763fc34edaaab9cf2bc7f04ec8b4a Cr-Commit-Position: refs/heads/master@{#371338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -558 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M components/arc.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M components/arc/arc_bridge_service.h View 8 chunks +0 lines, -11 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M components/arc/arc_service_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +0 lines, -4 lines 0 comments Download
D components/arc/common/video.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D components/arc/video/video_host_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/gpu/gpu_arc_video_service_host.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/browser/gpu/gpu_arc_video_service_host.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 4 chunks +0 lines, -20 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 4 chunks +0 lines, -44 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -23 lines 0 comments Download
M content/common/gpu/gpu_process_launch_causes.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu/media/gpu_arc_video_service.h View 1 chunk +0 lines, -68 lines 0 comments Download
D content/common/gpu/media/gpu_arc_video_service.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/browser/arc_video_host_delegate.h View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kcwu
4 years, 11 months ago (2016-01-25 09:20:53 UTC) #2
jam
lgtm, thanks
4 years, 11 months ago (2016-01-25 18:21:38 UTC) #3
dcheng
lgtm
4 years, 11 months ago (2016-01-25 18:39:51 UTC) #4
jam
(no need to get review from original reviewers)
4 years, 11 months ago (2016-01-25 21:04:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634443002/1
4 years, 11 months ago (2016-01-25 21:07:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/138733)
4 years, 11 months ago (2016-01-25 21:22:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634443002/1
4 years, 11 months ago (2016-01-25 22:28:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 22:38:53 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:40:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55e2b82591a763fc34edaaab9cf2bc7f04ec8b4a
Cr-Commit-Position: refs/heads/master@{#371338}

Powered by Google App Engine
This is Rietveld 408576698