Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 163443002: Version 1.2.0-dev.5.3 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemhtml.py
===================================================================
--- tools/dom/scripts/systemhtml.py (revision 32649)
+++ tools/dom/scripts/systemhtml.py (working copy)
@@ -512,10 +512,10 @@
for info in infos:
constructors.append(info.ConstructorInfo(self._interface.id))
- if factory_provider:
- assert factory_provider == info.factory_provider_name
- else:
- factory_provider = info.factory_provider_name
+ if factory_provider and factory_provider != info.factory_provider_name:
+ _logger.warn('Conflicting factory provider names: %s != %s' %
+ (factory_provider, info.factory_provider_name))
+ factory_provider = info.factory_provider_name
implementation_emitter = self._ImplementationEmitter()
« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698