Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1634423002: Add support to run emulator without ui on bots (Closed)

Created:
4 years, 11 months ago by Yoland Yan(Google)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support to run emulator without ui on bots BUG= Committed: https://crrev.com/eee4f0ab9679200cae959d708b2f77458d0b6de4 Cr-Commit-Position: refs/heads/master@{#371862}

Patch Set 1 #

Total comments: 4

Patch Set 2 : headless changes #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M build/android/avd.py View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 2 7 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Yoland Yan(Google)
4 years, 11 months ago (2016-01-27 04:28:01 UTC) #2
jbudorick
https://codereview.chromium.org/1634423002/diff/1/build/android/avd.py File build/android/avd.py (right): https://codereview.chromium.org/1634423002/diff/1/build/android/avd.py#newcode61 build/android/avd.py:61: run_parser.add_argument('--on-bot', action='store_true', this should probably be --headless https://codereview.chromium.org/1634423002/diff/1/build/android/pylib/utils/emulator.py File ...
4 years, 11 months ago (2016-01-27 15:58:42 UTC) #3
rnephew (Reviews Here)
4 years, 11 months ago (2016-01-27 16:01:15 UTC) #5
Yoland Yan(Google)
https://codereview.chromium.org/1634423002/diff/1/build/android/avd.py File build/android/avd.py (right): https://codereview.chromium.org/1634423002/diff/1/build/android/avd.py#newcode61 build/android/avd.py:61: run_parser.add_argument('--on-bot', action='store_true', On 2016/01/27 15:58:42, jbudorick wrote: > this ...
4 years, 11 months ago (2016-01-27 17:57:14 UTC) #6
mikecase (-- gone --)
lgtm with nits. https://codereview.chromium.org/1634423002/diff/20001/build/android/avd.py File build/android/avd.py (right): https://codereview.chromium.org/1634423002/diff/20001/build/android/avd.py#newcode63 build/android/avd.py:63: help='Running emulator on a bot through ...
4 years, 11 months ago (2016-01-27 18:02:41 UTC) #7
Yoland Yan(Google)
https://codereview.chromium.org/1634423002/diff/20001/build/android/avd.py File build/android/avd.py (right): https://codereview.chromium.org/1634423002/diff/20001/build/android/avd.py#newcode63 build/android/avd.py:63: help='Running emulator on a bot through ssh, launch ' ...
4 years, 10 months ago (2016-01-27 19:03:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634423002/20001
4 years, 10 months ago (2016-01-27 19:04:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634423002/40001
4 years, 10 months ago (2016-01-27 19:12:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-27 20:43:38 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 20:44:38 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eee4f0ab9679200cae959d708b2f77458d0b6de4
Cr-Commit-Position: refs/heads/master@{#371862}

Powered by Google App Engine
This is Rietveld 408576698