Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1634353003: Revert of [Android] Set enable_remoting=true by default (Closed)

Created:
4 years, 11 months ago by pkotwicz
Modified:
4 years, 11 months ago
Reviewers:
Lambros, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Set enable_remoting=true by default (patchset #1 id:1 of https://codereview.chromium.org/1619913002/ ) Reason for revert: This CL broke some of the internal builders which are building "all". remoting_cardboard_extract_native_lib should be behind an target_arch=="arm" if statement Original issue's description: > [Android] Set enable_remoting=true by default > > We set enable_remoting=true in the command line on the official builders. Set > enable_remoting=true as the default on Chromium as well. > > BUG=544298 > > Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175 > Cr-Commit-Position: refs/heads/master@{#371604} TBR=lambroslambrou@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=544298 Committed: https://crrev.com/0ed7abb706f40b9e925c17c203dfb428c793a855 Cr-Commit-Position: refs/heads/master@{#371685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
Created Revert of [Android] Set enable_remoting=true by default
4 years, 11 months ago (2016-01-27 01:49:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634353003/1
4 years, 11 months ago (2016-01-27 01:50:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 01:51:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ed7abb706f40b9e925c17c203dfb428c793a855 Cr-Commit-Position: refs/heads/master@{#371685}
4 years, 11 months ago (2016-01-27 01:53:23 UTC) #6
Dirk Pranke
4 years, 11 months ago (2016-01-27 04:00:02 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698