[MD settings] delay SetObserver in StartupUrl settings until page is loaded

[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
Committed: https://crrev.com/5e83747bbbcc58343f84b57e71503d3392e90ac4
Cr-Commit-Position: refs/heads/master@{#371987}

[dschuyler, 2016-01-26 23:25:41]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-01-26 23:34:27]

lgtm

please write your CL descriptions in first person, imperative, and present tense

i.e. "Move SetObserver" instead of "Moves" or "Moving"

https://codereview.chromium.org/1634353002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc (right):

https://codereview.chromium.org/1634353002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc:110:
base::Unretained(this)));
nit: \n

[dschuyler, 2016-01-26 23:35:56]

Description was changed from

==========
[MD settings] moved SetObserver

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

to

==========
[MD settings] move SetObserver

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

[dschuyler, 2016-01-26 23:40:17]

nit change.

https://codereview.chromium.org/1634353002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc (right):

https://codereview.chromium.org/1634353002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc:110:
base::Unretained(this)));
On 2016/01/26 23:34:27, Dan Beam wrote:
> nit: \n

Done.

[dschuyler, 2016-01-27 00:29:48]

Description was changed from

==========
[MD settings] move SetObserver

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

to

==========
[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

[dschuyler, 2016-01-28 01:58:19]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-01-28 01:58:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1634353002/#ps20001
(title: "review nit")

[commit-bot: I haz the power, 2016-01-28 01:59:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1634353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1634353002/20001

[commit-bot: I haz the power, 2016-01-28 03:22:16]

Description was changed from

==========
[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

to

==========
[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

[commit-bot: I haz the power, 2016-01-28 03:22:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 03:23:21]

Description was changed from

==========
[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503
==========

to

==========
[MD settings] delay SetObserver in StartupUrl settings until page is loaded

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503

Committed: https://crrev.com/5e83747bbbcc58343f84b57e71503d3392e90ac4
Cr-Commit-Position: refs/heads/master@{#371987}
==========

[commit-bot: I haz the power, 2016-01-28 03:23:22]

Patchset 2 (id:??) landed as
https://crrev.com/5e83747bbbcc58343f84b57e71503d3392e90ac4
Cr-Commit-Position: refs/heads/master@{#371987}