components/nacl/renderer/ppb_nacl_private_impl.cc - Issue 163433015: Add sandbox ISA and extra compile flag fields to PNaCl translation cache key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 163433015: Add sandbox ISA and extra compile flag fields to PNaCl translation cache key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/common/nacl_host_messages.h ('K') | « components/nacl/common/pnacl_types.h ('k') | ppapi/api/private/ppb_nacl_private.idl » ('j') | ppapi/api/private/ppb_nacl_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/ppb_nacl_private_impl.cc

diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc

index a9d909a5e322e8476a139b4205cf80f766e5e400..33c20043604a871cb037bfcbea4b892033cf27a1 100644

--- a/components/nacl/renderer/ppb_nacl_private_impl.cc

+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc

@@ -263,6 +263,8 @@ int32_t GetNexeFd(PP_Instance instance,

const char* last_modified,

const char* etag,

PP_Bool has_no_store_header,

+ const char* sandbox_isa,

+ const char* extra_flags,

PP_Bool* is_hit,

PP_FileHandle* handle,

struct PP_CompletionCallback callback) {

@@ -286,6 +288,8 @@ int32_t GetNexeFd(PP_Instance instance,

cache_info.last_modified = last_modified_time;

cache_info.etag = std::string(etag);

cache_info.has_no_store_header = PP_ToBool(has_no_store_header);

+ cache_info.sandbox_isa = std::string(sandbox_isa);

+ cache_info.extra_flags = std::string(extra_flags);

g_pnacl_resource_host.Get()->RequestNexeFd(

GetRoutingID(instance),