Add sandbox ISA and extra compile flag fields to PNaCl translation cache key

components/nacl/common/nacl_host_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included file, no traditional include guard.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/process/process.h"
@@ skipping 25 matching lines @@
   IPC_STRUCT_TRAITS_MEMBER(plugin_child_id)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(nacl::PnaclCacheInfo)
   IPC_STRUCT_TRAITS_MEMBER(pexe_url)
   IPC_STRUCT_TRAITS_MEMBER(abi_version)
   IPC_STRUCT_TRAITS_MEMBER(opt_level)
   IPC_STRUCT_TRAITS_MEMBER(last_modified)
   IPC_STRUCT_TRAITS_MEMBER(etag)
   IPC_STRUCT_TRAITS_MEMBER(has_no_store_header)
+  IPC_STRUCT_TRAITS_MEMBER(sandbox_isa)

[jvoung (off chromium), 2014/02/15 02:07:27]

You could also get the nacl arch from "OmahaQueryParams::GetNaclArch()" on the
cache/browser side w/out consulting the trusted plugin.

However, that was mostly intended for native NaCl + webstore and maybe PNaCl
would end up with different set of sandboxes from native NaCl so it might want
be independent.

[Derek Schuff, 2014/02/15 05:59:18]

Given that the rest of the cache information is coming from the plugin, and we
are adding the extra flag field anyway, I think it makes the most sense to keep
them all together for now. once we get rid of the plugin we can unify them.

edit: also it turns out that OmahaQueryParams is in Chrome and can't be depended
on by components, so it maybe should be moved or something, but that can be
another CL

+  IPC_STRUCT_TRAITS_MEMBER(extra_flags)
 IPC_STRUCT_TRAITS_END()
 
 // A renderer sends this to the browser process when it wants to start
 // a new instance of the Native Client process. The browser will launch
 // the process and return an IPC channel handle. This handle will only
 // be valid if the NaCl IPC proxy is enabled.
 IPC_SYNC_MESSAGE_CONTROL1_2(NaClHostMsg_LaunchNaCl,
                             nacl::NaClLaunchParams /* launch_params */,
                             nacl::NaClLaunchResult /* launch_result */,
                             std::string /* error_message */)
@@ skipping 36 matching lines @@
                      int /* Error ID */)
 
 // A renderer sends this to the browser process when it wants to
 // open a NaCl executable file from an installed application directory.
 IPC_SYNC_MESSAGE_CONTROL2_3(NaClHostMsg_OpenNaClExecutable,
                             int /* render_view_id */,
                             GURL /* URL of NaCl executable file */,
                             IPC::PlatformFileForTransit /* output file */,
                             uint64 /* file_token_lo */,
                             uint64 /* file_token_hi */)