Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 163433014: Re-enable ManuallyCloseMessageCenter in linux aura builds. (Closed)

Created:
6 years, 10 months ago by koss
Modified:
6 years, 10 months ago
Reviewers:
dewittj
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-enable ManuallyCloseMessageCenter in linux aura builds. Test tuns without errors or warning on my machine. BUG=163931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
koss
This one runs cleanly.
6 years, 10 months ago (2014-02-14 23:12:42 UTC) #1
koss
Runs with innocuous warnings.
6 years, 10 months ago (2014-02-14 23:13:14 UTC) #2
dewittj
lgtm
6 years, 10 months ago (2014-02-15 01:16:49 UTC) #3
koss
The CQ bit was checked by koss@chromium.org
6 years, 10 months ago (2014-02-15 01:34:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koss@chromium.org/163433014/1
6 years, 10 months ago (2014-02-15 01:34:16 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:39:44 UTC) #6
Message was sent while issue was closed.
Change committed as 251543

Powered by Google App Engine
This is Rietveld 408576698