Enable subpixel rendering in custom freetype2 library.

Enable subpixel rendering in custom freetype2 library.

Set FT_CONFIG_OPTION_SUBPIXEL_RENDERING in the custom
freetype2 library built for content_shell so that local
Chrome builds will honor the developer's font settings.

BUG=342077
TBR=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253485

[bungeman-skia, 2014-02-17 16:51:21]

I ran the linux_layout_rel on this just to see what would happen, and
fast/text/chromium-linux-fontconfig-renderstyle.html will need to be rebaselined
(again). See https://codereview.chromium.org/138123004 for the test expectations
change I made when creating this file. Dirk should also be aware of this change.

[Daniel Erat, 2014-02-18 22:16:08]

On 2014/02/17 16:51:21, bungeman1 wrote:
> I ran the linux_layout_rel on this just to see what would happen, and
> fast/text/chromium-linux-fontconfig-renderstyle.html will need to be
rebaselined
> (again). See https://codereview.chromium.org/138123004 for the test
expectations
> change I made when creating this file. Dirk should also be aware of this
change.

Thanks for the pointer! I don't have any recent rebaselining experience. Is
http://dev.chromium.org/developers/testing/webkit-layout-tests/testexpectatio...
accurate? Is NeedsRebaseline the correct keyword to use here, rather than
NeedsManualRebaseline?

[bungeman-chromium, 2014-02-18 22:24:29]

On 2014/02/18 22:16:08, Daniel Erat wrote:
> On 2014/02/17 16:51:21, bungeman1 wrote:
> > I ran the linux_layout_rel on this just to see what would happen, and
> > fast/text/chromium-linux-fontconfig-renderstyle.html will need to be
> rebaselined
> > (again). See https://codereview.chromium.org/138123004 for the test
> expectations
> > change I made when creating this file. Dirk should also be aware of this
> change.
> 
> Thanks for the pointer! I don't have any recent rebaselining experience. Is
>
http://dev.chromium.org/developers/testing/webkit-layout-tests/testexpectatio...
> accurate? Is NeedsRebaseline the correct keyword to use here, rather than
> NeedsManualRebaseline?

I'm not sure, but I think NeedsRebaseline should only go into the Blink
TestExpectations file. The issue here is Blink and Chromium being in separate
repositories. I checked in with NeedsManualRebaseline to the Chromium test
expectations, then checked in NeedsRebaseline to the Blink test expectations,
waited for that to roll into Chromium, then removed the NeedsManualRebaseline
from the Chromium test expectations. Then the bot eventually gets around to
doing the rebaseline. Note that it's ojan@ who takes care of the bot, so if you
have questions about that he'd be the one to ask.

[Dirk Pranke, 2014-02-18 23:32:54]

On 2014/02/18 22:24:29, bungeman2 wrote:
> On 2014/02/18 22:16:08, Daniel Erat wrote:
> > On 2014/02/17 16:51:21, bungeman1 wrote:
> > > I ran the linux_layout_rel on this just to see what would happen, and
> > > fast/text/chromium-linux-fontconfig-renderstyle.html will need to be
> > rebaselined
> > > (again). See https://codereview.chromium.org/138123004 for the test
> > expectations
> > > change I made when creating this file. Dirk should also be aware of this
> > change.
> > 
> > Thanks for the pointer! I don't have any recent rebaselining experience. Is
> >
>
http://dev.chromium.org/developers/testing/webkit-layout-tests/testexpectatio...
> > accurate? Is NeedsRebaseline the correct keyword to use here, rather than
> > NeedsManualRebaseline?
> 
> I'm not sure, but I think NeedsRebaseline should only go into the Blink
> TestExpectations file. 

That page should be correct.

NeedsRebaseline is probably the right version to use; it's not that important if
the downstream (pinned version) of the bots fails a test or two until the change
can be rolled. If necessary you can mark it as expected to fail in the
downstream expectations file. You definitely don't want to use both keywords, as
that would just be confusing :).

-- Dirk

[bungeman-chromium, 2014-02-19 16:59:50]

lgtm

[Daniel Erat, 2014-02-24 22:59:56]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2014-02-24 23:01:31]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2014-02-25 07:05:45]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-25 07:11:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 07:49:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 08:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 08:12:52]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Daniel Erat, 2014-02-25 08:15:35]

(Dirk, TBR-ing you for third_party/freetype2/OWNERS.)

[Daniel Erat, 2014-02-25 08:15:40]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-25 08:16:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 09:18:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 09:37:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 09:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 09:43:31]

Try jobs failed on following builders: mac_chromium_rel

[Daniel Erat, 2014-02-25 10:07:33]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-25 10:09:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-25 10:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 10:12:27]

Try jobs failed on following builders: mac_chromium_rel

[Daniel Erat, 2014-02-25 21:52:42]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2014-02-25 21:56:59]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2014-02-26 14:51:47]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-26 14:52:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/163433013/180001

[commit-bot: I haz the power, 2014-02-26 17:18:13]

Change committed as 253485