Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 163433012: Add a histogram "Download.FeedbackDialogEnabled" (Closed)

Created:
6 years, 10 months ago by felt
Modified:
6 years, 10 months ago
CC:
chromium-reviews, asanka, jar (doing other things), benjhayden+dwatch_chromium.org, tfarina, asvitkine+watch_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a histogram "Download.FeedbackDialogEnabled" This adds a new UMA histogram, "Download.FeedbackDialogEnabled." The histogram tells us how the user responded to the opt-in reporting dialog (enabled = true, disabled = false). BUG=312533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/ui/views/download/download_feedback_dialog_view.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
felt
Hi Alexei, can you please review this new histogram? Thanks, Adrienne
6 years, 10 months ago (2014-02-14 19:31:11 UTC) #1
Alexei Svitkine (slow)
I'm sheriffing today, so redirecting the review to another owner.
6 years, 10 months ago (2014-02-14 21:23:22 UTC) #2
Ilya Sherman
LGTM
6 years, 10 months ago (2014-02-14 21:24:14 UTC) #3
felt
Hi Peter, Can you please do an OWNERS review for chrome/browser/ui/views/download/download_feedback_dialog_view.cc? Small CL that adds ...
6 years, 10 months ago (2014-02-14 21:54:51 UTC) #4
Peter Kasting
LGTM
6 years, 10 months ago (2014-02-14 22:04:53 UTC) #5
felt
The CQ bit was checked by felt@chromium.org
6 years, 10 months ago (2014-02-14 22:07:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/163433012/1
6 years, 10 months ago (2014-02-14 22:09:35 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:12:57 UTC) #8
Message was sent while issue was closed.
Change committed as 251488

Powered by Google App Engine
This is Rietveld 408576698