Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163433006: Updated the finalized list of policies supported on iOS for M34. (Closed)

Created:
6 years, 10 months ago by Joao da Silva
Modified:
6 years, 10 months ago
Reviewers:
dconnelly
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Visibility:
Public.

Description

Updated the finalized list of policies supported on iOS for M34. BUG=275292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251374

Patch Set 1 #

Patch Set 2 : fixed unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -32 lines) Patch
M components/policy/core/common/generate_policy_source_unittest.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M components/policy/resources/policy_templates.json View 25 chunks +43 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 10 months ago (2014-02-14 09:45:20 UTC) #1
dconnelly
lgtm
6 years, 10 months ago (2014-02-14 10:59:15 UTC) #2
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 10 months ago (2014-02-14 11:04:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/163433006/1
6 years, 10 months ago (2014-02-14 11:04:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 12:05:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=124715
6 years, 10 months ago (2014-02-14 12:05:19 UTC) #6
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 10 months ago (2014-02-14 15:54:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/163433006/250001
6 years, 10 months ago (2014-02-14 15:54:41 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 18:39:16 UTC) #9
Message was sent while issue was closed. 
Change committed as 251374

Powered by Google App Engine
This is Rietveld 408576698