Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1634323002: Fix dock mode with 2+ external displays. (Closed)

Created:
4 years, 11 months ago by jdufault
Modified:
4 years, 10 months ago
Reviewers:
dnicoara, oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dock mode with 2+ external displays. BUG=575728 Committed: https://crrev.com/802c997e1e34fe6d4e445dad1af19f8b039b6cf9 Cr-Commit-Position: refs/heads/master@{#372480}

Patch Set 1 #

Patch Set 2 : Fix broken tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M ui/display/chromeos/display_configurator.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M ui/display/chromeos/update_display_configuration_task.cc View 1 1 chunk +26 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jdufault
dnicoara@, oshima@, PTAL. I'm not sure why it's important to base display decisions on number ...
4 years, 10 months ago (2016-01-28 19:14:55 UTC) #3
dnicoara
In terms of display configuration lgtm. oshima@ can comment if there are Ash related limitations.
4 years, 10 months ago (2016-01-29 22:23:26 UTC) #4
oshima
lgtm
4 years, 10 months ago (2016-01-29 23:21:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634323002/20001
4 years, 10 months ago (2016-01-29 23:34:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-30 00:06:02 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 00:07:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/802c997e1e34fe6d4e445dad1af19f8b039b6cf9
Cr-Commit-Position: refs/heads/master@{#372480}

Powered by Google App Engine
This is Rietveld 408576698