Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

Issue 1634293002: mojo filesystem: Simplify full file reading/writing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Further cleanup of pref store. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h
diff --git a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h
index 685b361f491002e6ab4fb785bd374211866de257..75cdead7ad910385570cdd5655cce2cc5f7d6076 100644
--- a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h
+++ b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h
@@ -140,14 +140,11 @@ class FilesystemJsonPrefStore
// Asynchronous implementation details of PerformWrite().
void OnTempFileWriteStart();
- void OnTempFileOpened(FileError err);
- void OnTempFileWrite(FileError err, uint32_t num_bytes_written);
- void OnTempFileClosed(FileError err);
+ void OnTempFileWrite(FileError err);
void OnTempFileRenamed(FileError err);
// Asynchronous implementation details of ReadPrefsAsync().
void OnPreferencesReadStart();
- void OnPreferencesFileOpened(FileError err);
void OnPreferencesFileRead(FileError err, mojo::Array<uint8_t> contents);
const std::string path_;
@@ -158,9 +155,6 @@ class FilesystemJsonPrefStore
// |filesystem. See OpenFilesystem().
DirectoryPtr directory_;
- FilePtr preferences_file_;
- FilePtr temporary_file_;
-
scoped_ptr<base::DictionaryValue> prefs_;
bool read_only_;

Powered by Google App Engine
This is Rietveld 408576698