Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1634273003: Marked parsing as failed for invalid compound. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Marked parsing as failed for invalid compound. If we return nullptr trying to consume a compound, and all tokens have been consumed, we don't recognize that as a parse failure if a valid selector precedes the compound. Set m_failedParsing to true to notice we have an invalid selector. R=timloh@chromium.org BUG=581257 Committed: https://crrev.com/acce4131402e62abdee469c445849c1036357e6e Cr-Commit-Position: refs/heads/master@{#371760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634273003/1
4 years, 11 months ago (2016-01-27 00:19:09 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 01:40:29 UTC) #4
Timothy Loh
lgtm (btw you didn't actually send this out)
4 years, 11 months ago (2016-01-27 08:07:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634273003/1
4 years, 11 months ago (2016-01-27 08:29:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 08:35:00 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/acce4131402e62abdee469c445849c1036357e6e Cr-Commit-Position: refs/heads/master@{#371760}
4 years, 11 months ago (2016-01-27 08:36:53 UTC) #10
rune
4 years, 11 months ago (2016-01-27 08:53:13 UTC) #11
Message was sent while issue was closed.
On 2016/01/27 08:07:46, Timothy Loh wrote:
> lgtm (btw you didn't actually send this out)

Sorry, it did not appear in my unsent category.

Powered by Google App Engine
This is Rietveld 408576698