Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634263002: ash: Fix building on linux with use_ash turned on. (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Fix building on linux with use_ash turned on. BUG=none Committed: https://crrev.com/c634ef095cdefe731c1904fb3b4398420103bb93 Cr-Commit-Position: refs/heads/master@{#371613}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
4 years, 11 months ago (2016-01-26 20:58:31 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-26 21:43:17 UTC) #3
sky
I'm not sure how long this will work.
4 years, 11 months ago (2016-01-26 21:43:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634263002/20001
4 years, 11 months ago (2016-01-26 21:56:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 22:16:39 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 22:17:55 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c634ef095cdefe731c1904fb3b4398420103bb93
Cr-Commit-Position: refs/heads/master@{#371613}

Powered by Google App Engine
This is Rietveld 408576698