Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1634203002: Fix remote frame origin access in ContentWatcher::NotifyBrowserOfChange. (Closed)

Created:
4 years, 11 months ago by alexmos
Modified:
4 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix remote frame origin access in ContentWatcher::NotifyBrowserOfChange. The frame traversal in that function was accessing the frame's SecurityOrigin via the document(), which is incorrect in the case of remote frames which have no document(). BUG=581274 Committed: https://crrev.com/1cf50512acf1e7098750465e4cb94a27d614c480 Cr-Commit-Position: refs/heads/master@{#371592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/content_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alexmos
Devlin, please take a look. This is just an easy fix for a crash we ...
4 years, 11 months ago (2016-01-26 18:27:50 UTC) #2
Devlin
lgtm
4 years, 11 months ago (2016-01-26 19:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634203002/1
4 years, 11 months ago (2016-01-26 19:53:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 20:48:12 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 20:49:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cf50512acf1e7098750465e4cb94a27d614c480
Cr-Commit-Position: refs/heads/master@{#371592}

Powered by Google App Engine
This is Rietveld 408576698