Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163413005: DevTools: [CSS] remove CSS Regions experiment from DevTools. (Closed)

Created:
6 years, 10 months ago by lushnikov
Modified:
6 years, 10 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, arv+blink, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., mstensho+blink_opera.com, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, mstensho (USE GERRIT)
Visibility:
Public.

Description

DevTools: [CSS] remove CSS Regions experiment from DevTools. This patch removes CSS Regions from DevTools back-end and front-end files. BUG=341506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1415 lines) Patch
M Source/core/dom/NamedFlowCollection.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 8 chunks +0 lines, -20 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 9 chunks +0 lines, -264 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +0 lines, -7 lines 0 comments Download
D Source/devtools/front_end/CSSNamedFlowCollectionsView.js View 1 chunk +0 lines, -433 lines 0 comments Download
D Source/devtools/front_end/CSSNamedFlowView.js View 1 chunk +0 lines, -256 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 6 chunks +0 lines, -232 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 2 chunks +0 lines, -14 lines 0 comments Download
D Source/devtools/front_end/Images/namedFlowOverflow.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/regionEmpty.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/regionFit.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/regionOverset.png View Binary file 0 comments Download
M Source/devtools/front_end/Settings.js View 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/cssNamedFlows.css View 1 chunk +0 lines, -99 lines 0 comments Download
M Source/devtools/protocol.json View 3 chunks +0 lines, -67 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
lushnikov
Please take a look.
6 years, 10 months ago (2014-02-13 16:39:53 UTC) #1
apavlov
lgtm
6 years, 10 months ago (2014-02-14 08:32:49 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 10 months ago (2014-02-14 08:34:59 UTC) #3
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 10 months ago (2014-02-14 08:35:47 UTC) #4
eseidel
Thank you.
6 years, 10 months ago (2014-02-14 10:38:39 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 10 months ago (2014-02-14 12:18:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/163413005/1
6 years, 10 months ago (2014-02-14 12:18:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 12:40:04 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16034
6 years, 10 months ago (2014-02-14 12:40:05 UTC) #9
pfeldman
lgtm
6 years, 10 months ago (2014-02-14 12:54:53 UTC) #10
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 10 months ago (2014-02-14 12:54:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/163413005/1
6 years, 10 months ago (2014-02-14 12:55:15 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:06:02 UTC) #13
Message was sent while issue was closed. 
Change committed as 167195

Powered by Google App Engine
This is Rietveld 408576698