Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 163413003: Add a premonomorphic state to the call target cache. (Closed)

Created:
6 years, 10 months ago by mvstanton
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Kasper Lund
Visibility:
Public.

Description

Add a premonomorphic state to the call target cache. From a CL by kasperl: https://codereview.chromium.org/162903004/ R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19402

Patch Set 1 #

Patch Set 2 : Missing a64 port added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -8 lines) Patch
M src/a64/code-stubs-a64.cc View 1 2 chunks +18 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +18 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +17 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/allocation-site-info.js View 17 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Toon, Could you look over the CL from Kasperl, with an ARM port by ...
6 years, 10 months ago (2014-02-13 12:57:11 UTC) #1
Toon Verwaest
Looks good to me if performance is ok (and platform ports are added)
6 years, 10 months ago (2014-02-13 13:17:01 UTC) #2
mvstanton
Hi Toon, performance appears to be okay. Also, missing a64 port added. --Michael
6 years, 10 months ago (2014-02-14 09:04:04 UTC) #3
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-14 15:10:48 UTC) #4
mvstanton
6 years, 10 months ago (2014-02-17 11:59:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698