Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 163413002: Added browser test for Captive Portal window ctor and dtor. (Closed)

Created:
6 years, 10 months ago by ygorshenin1
Modified:
6 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Added browser test for Captive Portal window ctor and dtor. BUG=294477 TEST=browser_tests:CaptivePortalWindowCtorDtor* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251071

Patch Set 1 #

Patch Set 2 : Fix to CaptivePortalWindowProxy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -3 lines) Patch
M chrome/browser/chromeos/login/captive_portal_window_browsertest.cc View 3 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_proxy.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_proxy.cc View 1 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ygorshenin1
6 years, 10 months ago (2014-02-13 14:16:35 UTC) #1
Nikita (slow)
lgtm
6 years, 10 months ago (2014-02-13 15:03:23 UTC) #2
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 10 months ago (2014-02-13 15:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/163413002/40001
6 years, 10 months ago (2014-02-13 15:05:04 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:22:26 UTC) #5
Message was sent while issue was closed.
Change committed as 251071

Powered by Google App Engine
This is Rietveld 408576698