Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ui/gfx/render_text.cc

Issue 1634103003: Fix gfx::Canvas::DrawStringRectWithHalo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/test/data/compositor/string_faded.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index b9397062d6ce91035cd763c1c8d2561fbdbcedf5..b0702d4fef6403d421c019b338028df5051de849 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -23,6 +23,7 @@
#include "third_party/skia/include/core/SkFontStyle.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/effects/SkGradientShader.h"
+#include "third_party/skia/include/effects/SkMorphologyImageFilter.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/safe_integer_conversions.h"
@@ -256,6 +257,10 @@ void SkiaTextRenderer::SetShader(sk_sp<SkShader> shader) {
paint_.setShader(std::move(shader));
}
+void SkiaTextRenderer::SetHaloEffect() {
+ paint_.setImageFilter(SkDilateImageFilter::Make(1, 1, nullptr));
+}
+
void SkiaTextRenderer::SetUnderlineMetrics(SkScalar thickness,
SkScalar position) {
underline_thickness_ = thickness;
@@ -849,6 +854,8 @@ void RenderText::Draw(Canvas* canvas) {
if (!text().empty()) {
internal::SkiaTextRenderer renderer(canvas);
+ if (halo_effect())
+ renderer.SetHaloEffect();
DrawVisualText(&renderer);
}
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/test/data/compositor/string_faded.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698