Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: ui/gfx/render_text.h

Issue 1634103003: Fix gfx::Canvas::DrawStringRectWithHalo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check halo pixels Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 522cc4d0d9b9877c5fe619b9da345d5068f1fb39..0764768f874a61ccdc6a314bc5c5362ceb7fb5ae 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -65,6 +65,7 @@ class GFX_EXPORT SkiaTextRenderer {
void SetFontWithStyle(const Font& font, int font_style);
void SetForegroundColor(SkColor foreground);
void SetShader(SkShader* shader);
+ void SetHaloEffect();
// Sets underline metrics to use if the text will be drawn with an underline.
// If not set, default values based on the size of the text will be used. The
// two metrics must be set together.
@@ -300,6 +301,9 @@ class GFX_EXPORT RenderText {
subpixel_rendering_suppressed_ = suppressed;
}
+ bool halo_effect() const { return halo_effect_; }
+ void set_halo_effect(bool halo_effect) { halo_effect_ = halo_effect; }
+
const SelectionModel& selection_model() const { return selection_model_; }
const Range& selection() const { return selection_model_.selection(); }
@@ -817,6 +821,9 @@ class GFX_EXPORT RenderText {
// A list of valid display text line break positions.
BreakList<size_t> line_breaks_;
+ // Draw text with 1px border.
+ bool halo_effect_ = false;
+
// Lines computed by EnsureLayout. These should be invalidated upon
// OnLayoutTextAttributeChanged and OnDisplayTextAttributeChanged calls.
std::vector<internal::Line> lines_;
« no previous file with comments | « ui/gfx/canvas_skia.cc ('k') | ui/gfx/render_text.cc » ('j') | ui/gfx/render_text.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698