Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1634103002: views/mus: Make PlatformWindowMus be responsible for setting-up the BitmapUploader. (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Make PlatformWindowMus be responsible for setting-up the BitmapUploader. Doing this allows using PlatformWindowMus and have it paint correctly without needing to create a WindowTreeHostMus too. BUG=none Committed: https://crrev.com/68dcc38cd5843613dd8c6256b38eca9356eecaa5 Cr-Commit-Position: refs/heads/master@{#371540}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M ui/views/mus/platform_window_mus.h View 3 chunks +15 lines, -0 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 1 2 4 chunks +0 lines, -14 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sadrul
4 years, 11 months ago (2016-01-26 06:06:09 UTC) #2
sky
LGTM - nuke any stale includes in WindowTreeHostMus too
4 years, 11 months ago (2016-01-26 14:18:38 UTC) #3
sadrul
On 2016/01/26 14:18:38, sky wrote: > LGTM - nuke any stale includes in WindowTreeHostMus too ...
4 years, 11 months ago (2016-01-26 17:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634103002/40001
4 years, 11 months ago (2016-01-26 17:16:55 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 18:14:01 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:15:16 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68dcc38cd5843613dd8c6256b38eca9356eecaa5
Cr-Commit-Position: refs/heads/master@{#371540}

Powered by Google App Engine
This is Rietveld 408576698