Ensure all infobars disappear when navigating between pages with infobars.

Ensure all infobars disappear when navigating between pages with infobars.

Previously, when navigating from one page with 3+ infobars to another
page with infobars, the animation would show only one or two infobars
hiding then one or two infobars appearing, even though all the existing
infobars should disappear, then all the new infobars should appear. To
the user, it appeared as if some of the new infobars had been there all
along (peeking up in the back), which is confusing and wrong.

This strange behavior was caused by the logic for deciding when to show
a hiding or appearing animation. This logic didn't associate a
particular infobar with a particular view; it just ensured that the
number of views matched the number of infobars. So, if infobars were
removed and then new infobars were quickly added, there would be fewer
animations than expected.

The new code explicitly associates an infobar with each view, so if all
the infobars are removed and then several new ones added, the animations
will reflect that correctly.

BUG=396223
Committed: https://crrev.com/ee701bbdcafe290b5961cdf98ebf366af27c3890
Cr-Commit-Position: refs/heads/master@{#371635}

[newt (away), 2016-01-26 03:45:06]

newt@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[newt (away), 2016-01-26 03:45:06]

PTAL

p.s. To see the broken behavior that this CL is fixing, load your infobar
apocalypse page, wait for infobars to appear, then hit refresh.

[gone, 2016-01-26 22:02:27]

lgtm

[newt (away), 2016-01-26 22:43:24]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2016-01-26 22:44:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1634083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1634083002/1

[commit-bot: I haz the power, 2016-01-26 23:41:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 23:42:29]

Description was changed from

==========
Ensure all infobars disappear when navigating between pages with infobars.

Previously, when navigating from one page with 3+ infobars to another
page with infobars, the animation would show only one or two infobars
hiding then one or two infobars appearing, even though all the existing
infobars should disappear, then all the new infobars should appear. To
the user, it appeared as if some of the new infobars had been there all
along (peeking up in the back), which is confusing and wrong.

This strange behavior was caused by the logic for deciding when to show
a hiding or appearing animation. This logic didn't associate a
particular infobar with a particular view; it just ensured that the
number of views matched the number of infobars. So, if infobars were
removed and then new infobars were quickly added, there would be fewer
animations than expected.

The new code explicitly associates an infobar with each view, so if all
the infobars are removed and then several new ones added, the animations
will reflect that correctly.

BUG=396223
==========

to

==========
Ensure all infobars disappear when navigating between pages with infobars.

Previously, when navigating from one page with 3+ infobars to another
page with infobars, the animation would show only one or two infobars
hiding then one or two infobars appearing, even though all the existing
infobars should disappear, then all the new infobars should appear. To
the user, it appeared as if some of the new infobars had been there all
along (peeking up in the back), which is confusing and wrong.

This strange behavior was caused by the logic for deciding when to show
a hiding or appearing animation. This logic didn't associate a
particular infobar with a particular view; it just ensured that the
number of views matched the number of infobars. So, if infobars were
removed and then new infobars were quickly added, there would be fewer
animations than expected.

The new code explicitly associates an infobar with each view, so if all
the infobars are removed and then several new ones added, the animations
will reflect that correctly.

BUG=396223

Committed: https://crrev.com/ee701bbdcafe290b5961cdf98ebf366af27c3890
Cr-Commit-Position: refs/heads/master@{#371635}
==========

[commit-bot: I haz the power, 2016-01-26 23:42:30]

Patchset 1 (id:??) landed as
https://crrev.com/ee701bbdcafe290b5961cdf98ebf366af27c3890
Cr-Commit-Position: refs/heads/master@{#371635}