Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h

Issue 1634073003: Remove references between RTCPeerConnection and RTCDataChannel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove RTCPeerConnection reference from RTCDataChannel Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
index f2a3a9017ebf8187d1f68a84f9255fe1209b8d13..fdda686beae88244eb8a8063db2a9dc92c444129 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
@@ -49,8 +49,8 @@ class MODULES_EXPORT RTCDataChannel final
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCDataChannel);
DEFINE_WRAPPERTYPEINFO();
public:
- static RTCDataChannel* create(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<WebRTCDataChannelHandler>);
- static RTCDataChannel* create(ExecutionContext*, RTCPeerConnection*, WebRTCPeerConnectionHandler*, const String& label, const WebRTCDataChannelInit&, ExceptionState&);
+ static RTCDataChannel* create(ExecutionContext*, PassOwnPtr<WebRTCDataChannelHandler>);
+ static RTCDataChannel* create(ExecutionContext*, WebRTCPeerConnectionHandler*, const String& label, const WebRTCDataChannelInit&, ExceptionState&);
~RTCDataChannel() override;
ReadyState getHandlerState() const;
@@ -88,14 +88,10 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
- void stop();
-
// EventTarget
const AtomicString& interfaceName() const override;
ExecutionContext* executionContext() const override;
- void clearWeakMembers(Visitor*);
-
// Oilpan: need to eagerly finalize m_handler
EAGERLY_FINALIZE();
DECLARE_VIRTUAL_TRACE();
@@ -108,7 +104,7 @@ public:
void didDetectError() override;
private:
- RTCDataChannel(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<WebRTCDataChannelHandler>);
+ RTCDataChannel(ExecutionContext*, PassOwnPtr<WebRTCDataChannelHandler>);
void scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event>);
void scheduledEventTimerFired(Timer<RTCDataChannel>*);
@@ -117,8 +113,6 @@ private:
OwnPtr<WebRTCDataChannelHandler> m_handler;
- bool m_stopped;
-
WebRTCDataChannelHandlerClient::ReadyState m_readyState;
enum BinaryType {
@@ -130,8 +124,6 @@ private:
Timer<RTCDataChannel> m_scheduledEventTimer;
WillBeHeapVector<RefPtrWillBeMember<Event>> m_scheduledEvents;
- WeakMember<RTCPeerConnection> m_connection;
-
unsigned m_bufferedAmountLowThreshold;
FRIEND_TEST_ALL_PREFIXES(RTCDataChannelTest, BufferedAmountLow);
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698