Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1634023002:
Use devicePixelRatio in image set (Closed)
|
Created:
4 years, 11 months ago by oshima Modified:
4 years, 10 months ago Reviewers:
eae CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse devicePixelRatio in image set instead of deviceScaleFactor
BUG=485650, 580373
TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html
Committed: https://crrev.com/4835c7b56028b6e9ecadaa95ed5cf30bb9456941
Cr-Commit-Position: refs/heads/master@{#372163}
Patch Set 1 : #Patch Set 2 : rebase #Patch Set 3 : rebase #
Messages
Total messages: 26 (15 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Use devicePixelRatio in image set BUG= patch from issue 1614753002 at patchset 20001 (http://crrev.com/1614753002#ps20001) ========== to ========== Use devicePixelRatio in image set BUG=485650 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ==========
oshima@chromium.org changed reviewers: + eae@chromium.org
Description was changed from ========== Use devicePixelRatio in image set BUG=485650 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ========== to ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634023002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634023002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping?
LGTM
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634023002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ========== to ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650,580373 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ==========
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1634023002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634023002/60001
Message was sent while issue was closed.
Description was changed from ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650,580373 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ========== to ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650,580373 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650,580373 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html ========== to ========== Use devicePixelRatio in image set instead of deviceScaleFactor BUG=485650,580373 TEST=LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html Committed: https://crrev.com/4835c7b56028b6e9ecadaa95ed5cf30bb9456941 Cr-Commit-Position: refs/heads/master@{#372163} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4835c7b56028b6e9ecadaa95ed5cf30bb9456941 Cr-Commit-Position: refs/heads/master@{#372163} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
