Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 1633933002: cc: Don't allocate 0-size discardable memory. (Closed)

Created:
4 years, 11 months ago by vmpstr
Modified:
4 years, 11 months ago
Reviewers:
reveman, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't allocate 0-size discardable memory. This patch ensures that when processing images we don't try to allocate 0 bytes of discardable memory. For now, allocate 1 byte with a TODO to skip these images altogether. R=enne BUG=579498 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/22a81440352f62715f51e6a922471a0e824ba8cf Cr-Commit-Position: refs/heads/master@{#371413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/tiles/image_decode_controller.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vmpstr
Please take a look.
4 years, 11 months ago (2016-01-25 22:17:16 UTC) #2
reveman
lgtm
4 years, 11 months ago (2016-01-26 00:36:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633933002/1
4 years, 11 months ago (2016-01-26 00:40:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 01:46:12 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:47:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a81440352f62715f51e6a922471a0e824ba8cf
Cr-Commit-Position: refs/heads/master@{#371413}

Powered by Google App Engine
This is Rietveld 408576698