Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1633903002: test: stop building tons of copies of gtest/gmock objects (Closed)

Created:
4 years, 11 months ago by vapier
Modified:
4 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test: stop building tons of copies of gtest/gmock objects The current makefile ends up building ~17 copies of the gtest/gmock objects -- every test that refers to the cc files directly will have its own copy. This is because the build doesn't know if CFLAGS and such have changed between each target (and in some cases, they are). Create a new libtesting.a target to hold a single copy of these files and update all of the unittests to link that in. This speeds up the build a bit especially when you aren't using ccache. This does mean we can no longer build gtest/gmock with unique flags, but we haven't wanted that so far, so clearly no one wants that. BUG=chromium:579384 TEST=`make check` passes R=thestig@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/83f0e6a31cd7e86e36a2a33085e86f8cc2a6fa7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -1667 lines) Patch
M Makefile.am View 17 chunks +69 lines, -96 lines 0 comments Download
M Makefile.in View 116 chunks +309 lines, -1571 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vapier
4 years, 11 months ago (2016-01-25 21:59:20 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-25 22:26:16 UTC) #3
vapier
4 years, 11 months ago (2016-01-25 22:41:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83f0e6a31cd7e86e36a2a33085e86f8cc2a6fa7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698