Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 16339009: Switch gdb command parameters parsing algorithm from UNIX rules to Windows rules. (Closed)

Created:
7 years, 6 months ago by halyavin
Modified:
7 years, 6 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M gdb/utils.c View 1 5 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
halyavin
7 years, 6 months ago (2013-06-10 14:06:28 UTC) #1
eaeltsin
lgtm Conversion function might be optimized to have less passes and less malloc's, however, it ...
7 years, 6 months ago (2013-06-10 14:22:03 UTC) #2
halyavin
7 years, 6 months ago (2013-06-10 15:16:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r055a0f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698