build: clean up .dwo files

build: clean up .dwo files

When building with -gsplit-dwarf, the generated dwo files are left behind
even when you `make clean`.  Fix that up.

BUG=chromium:579384
TEST=`./configure CXXFLAGS='-O -gsplit-dwarf' && make && make clean` removes dwo files now
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/0f0b0f367b1af511cab327e803a2621ea69bc1ed

[vapier, 2016-01-25 21:54:06]

vapier@chromium.org changed reviewers:
+ mark@chromium.org

[vapier, 2016-01-25 21:54:07]

wrote the patch before you said "don't bother" :)

[Mark Mentovai, 2016-01-25 23:36:42]

LGTM

https://codereview.chromium.org/1633893002/diff/1/Makefile.am
File Makefile.am (right):

https://codereview.chromium.org/1633893002/diff/1/Makefile.am#newcode1332
Makefile.am:1332: -find src -name '*.dwo' -exec rm -f {} +
This is run from the objdir when objdir’s not srcdir, right?

[vapier, 2016-01-25 23:39:42]

https://codereview.chromium.org/1633893002/diff/1/Makefile.am
File Makefile.am (right):

https://codereview.chromium.org/1633893002/diff/1/Makefile.am#newcode1332
Makefile.am:1332: -find src -name '*.dwo' -exec rm -f {} +
yep, rules are processed in $builddir, not $srcdir.  i actually verified in an
out-of-tree scenario :).

[vapier, 2016-01-25 23:41:01]

Description was changed from

==========
build: clean up .dwo files

When building with -gsplit-dwarf, the generated dwo files are left behind
even when you `make clean`.  Fix that up.

BUG=chromium:579384
TEST=`./configure CXXFLAGS='-O -gsplit-dwarf' && make && make clean` removes dwo
files now
==========

to

==========
build: clean up .dwo files

When building with -gsplit-dwarf, the generated dwo files are left behind
even when you `make clean`.  Fix that up.

BUG=chromium:579384
TEST=`./configure CXXFLAGS='-O -gsplit-dwarf' && make && make clean` removes dwo
files now
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/0f0b0f367b1af511cab327e...
==========

[vapier, 2016-01-25 23:41:02]

Committed patchset #1 (id:1) manually as
0f0b0f367b1af511cab327e803a2621ea69bc1ed (presubmit successful).