Support for constructor references in constant serializer and prelinker.

pkg/analyzer/tool/summary/idl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is an "idl" style description of the summary format.  It is not
  * executed directly; instead it is parsed and transformed into code that
  * implements the summary format.
  *
  * The code generation process introduces the following non-typical semantics:
@@ skipping 560 matching lines @@
    */
   pushReference,
 
   /**
    * Pop the top `n` values from the stack (where `n` is obtained from
    * [UnlinkedConst.ints]) into a list (filled from the end) and take the next
    * `n` values from [UnlinkedConst.strings] and use the lists of names and
    * values to create named arguments.  Then pop the top `m` values from the
    * stack (where `m` is obtained from [UnlinkedConst.ints]) into a list (filled
    * from the end) and use them as positional arguments.  Use the lists of
-   * positional and names arguments to invoke a constant constructor whose name
-   * is obtained from [UnlinkedConst.strings], and whose class is obtained from
-   * [UnlinkedConst.references], and push the resulting value back onto the
+   * positional and names arguments to invoke a constant constructor obtained
+   * from [UnlinkedConst.references], and push the resulting value back onto the
    * stack.
    *
    * Note that for an invocation of the form `const a.b(...)` (where no type
    * arguments are specified), it is impossible to tell from the unresolved AST
    * alone whether `a` is a class name and `b` is a constructor name, or `a` is
-   * a prefix name and `b` is a class name.  In this case it is presumed that
-   * `a` is a prefix name and `b` is a class name.
-   *
-   * TODO(paulberry): figure out how to resolve this ambiguity in the
-   * "prelinked" part of the summary.
+   * a prefix name and `b` is a class name.  For consistency between AST based
+   * and elements based summaries, references to default constructors are always
+   * recorded as references to corresponding classes.
    */
   invokeConstructor,
 
   /**
    * Pop the top n values from the stack (where n is obtained from
    * [UnlinkedConst.ints]), place them in a [List], and push the result back
    * onto the stack.  The type parameter for the [List] is implicitly `dynamic`.
    */
   makeUntypedList,
 
@@ skipping 854 matching lines @@
   int propagatedTypeSlot;
 
   /**
    * If this variable is inferrable, nonzero slot id identifying which entry in
    * [LinkedLibrary.types] contains the inferred type for this variable.  If
    * there is no matching entry in [LinkedLibrary.types], then no type was
    * inferred for this variable, so its static type is `dynamic`.
    */
   int inferredTypeSlot;
 }