Add support for tasks to determine whether they are appropriate for a given target

Add support for tasks to determine whether they are appropriate for a given target

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5a07d5c5595f412dbbad056504b52b182c521206

[Brian Wilkerson, 2016-01-25 19:21:39]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[scheglov, 2016-01-25 19:24:49]

LGTM

[Paul Berry, 2016-01-25 20:12:40]

lgtm

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/src/task/m...
File pkg/analyzer/lib/src/task/model.dart (right):

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/src/task/m...
pkg/analyzer/lib/src/task/model.dart:142: {IsAppropriateFor isAppropriateFor})
Suggestion: make the default value of isAppropriateFor a static function that
returns true for any target.  Then the implementation of the isAppropriateFor()
method below can be simplified.

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:40: * returns `true` if the task is appropriate
for thetarget. Such functions are
s/thetarget/the target/

[Brian Wilkerson, 2016-01-25 20:27:36]

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/src/task/m...
File pkg/analyzer/lib/src/task/model.dart (right):

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/src/task/m...
pkg/analyzer/lib/src/task/model.dart:142: {IsAppropriateFor isAppropriateFor})
> Suggestion: make the default value of isAppropriateFor a static function that
> returns true for any target.

Good suggestion, but I modified it somewhat. Instead of using this as the
default value of the parameter I check for null in the assignment to the field.
That way, if a client passes in null explicitly we'll overwrite it.

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/1633823002/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:40: * returns `true` if the task is appropriate
for thetarget. Such functions are
Done

[Brian Wilkerson, 2016-01-25 20:28:45]

Description was changed from

==========
Add support for tasks to determine whether they are appropriate for a given
target
==========

to

==========
Add support for tasks to determine whether they are appropriate for a given
target

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5a07d5c5595f412dbbad056504b52b182c521206
==========

[Brian Wilkerson, 2016-01-25 20:28:46]

Committed patchset #1 (id:1) manually as
5a07d5c5595f412dbbad056504b52b182c521206 (presubmit successful).