Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: tools/android/loading/request_dependencies_lens_unittest.py

Issue 1633813005: tools/android/loading: Add support for multiple redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/loading/request_dependencies_lens.py ('k') | tools/android/loading/request_track.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/loading/request_dependencies_lens_unittest.py
diff --git a/tools/android/loading/request_dependencies_lens_unittest.py b/tools/android/loading/request_dependencies_lens_unittest.py
index 4fc5d9072d80f379eb9e2185744d80a446e4e76c..0ab7403bdf2b18e7523822f7752876b769ec5deb 100644
--- a/tools/android/loading/request_dependencies_lens_unittest.py
+++ b/tools/android/loading/request_dependencies_lens_unittest.py
@@ -13,9 +13,17 @@ import test_utils
class RequestDependencyLensTestCase(unittest.TestCase):
_REDIRECT_REQUEST = Request.FromJsonDict(
- {'url': 'http://bla.com', 'request_id': '1234.1.redirect',
+ {'url': 'http://bla.com', 'request_id': '1234.redirect.1',
'initiator': {'type': 'other'},
'timestamp': 1, 'timing': TimingFromDict({})})
+ _REDIRECTED_REQUEST = Request.FromJsonDict({
+ 'url': 'http://bla.com',
+ 'request_id': '1234.1',
+ 'frame_id': '123.1',
+ 'initiator': {'type': 'redirect',
+ 'initiating_request': '1234.redirect.1'},
+ 'timestamp': 2,
+ 'timing': TimingFromDict({})})
_REQUEST = Request.FromJsonDict({'url': 'http://bla.com',
'request_id': '1234.1',
'frame_id': '123.1',
@@ -55,7 +63,7 @@ class RequestDependencyLensTestCase(unittest.TestCase):
def testRedirectDependency(self):
loading_trace = test_utils.LoadingTraceFromEvents(
- [self._REDIRECT_REQUEST, self._REQUEST])
+ [self._REDIRECT_REQUEST, self._REDIRECTED_REQUEST])
request_dependencies_lens = RequestDependencyLens(loading_trace)
deps = request_dependencies_lens.GetRequestDependencies()
self.assertEquals(1, len(deps))
@@ -86,7 +94,7 @@ class RequestDependencyLensTestCase(unittest.TestCase):
def testSeveralDependencies(self):
loading_trace = test_utils.LoadingTraceFromEvents(
- [self._REDIRECT_REQUEST, self._REQUEST, self._JS_REQUEST,
+ [self._REDIRECT_REQUEST, self._REDIRECTED_REQUEST, self._JS_REQUEST,
self._JS_REQUEST_2])
request_dependencies_lens = RequestDependencyLens(loading_trace)
deps = request_dependencies_lens.GetRequestDependencies()
« no previous file with comments | « tools/android/loading/request_dependencies_lens.py ('k') | tools/android/loading/request_track.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698